From #866 (review):
Minor optional suggestion: move ResolveSubscriberSpec to another package if other controllers will be using it. That makes its intended use as a generic helper method more clear to future maintainers.
ResolveSubscriberSpec is currently a method in the Subscription Controller, but is used by multiple controllers (Subscription and Trigger for now). As it is used by multiple controllers, it should be moved out of the existing location and into a more generic one.
From #866 (review):
ResolveSubscriberSpec is currently a method in the Subscription Controller, but is used by multiple controllers (Subscription and Trigger for now). As it is used by multiple controllers, it should be moved out of the existing location and into a more generic one.