Make ResolveSubscriberSpec a public method

[Harwayne]

Proposed Changes

• Make ResolveSubscriberSpec a public method, so that it can be called by other Controllers that need to do the same resolution logic.

This is being used in #788. Moving to a separate PR for ease of review.

Release Note

NONE

[grantr]

/lgtm

Minor optional suggestion: move ResolveSubscriberSpec to another package if other controllers will be using it. That makes its intended use as a generic helper method more clear to future maintainers.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Harwayne,grantr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Harwayne]

Minor optional suggestion: move ResolveSubscriberSpec to another package if other controllers will be using it. That makes its intended use as a generic helper method more clear to future maintainers.

I agree, created #867.