Skip to content

Broker, Trigger, and Namespace Controllers#788

Merged
knative-prow-robot merged 191 commits into
knative:masterfrom
Harwayne:broker-new-model
Mar 18, 2019
Merged

Broker, Trigger, and Namespace Controllers#788
knative-prow-robot merged 191 commits into
knative:masterfrom
Harwayne:broker-new-model

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Feb 7, 2019 •
edited
Loading

Proposed Changes

  • Initial implementations of the Broker and Trigger controllers.
  • Initial implementation of the eventing Namespace watcher.

With thanks to:

  • @nachocano - Who authored large swathes of the PR.
  • @grantr - Who also authored parts of the PR.
  • @vaikas-google and @n3wscott - For testing the intermediate states of the PR.

Release Note

Need to apply the two new types (Broker and Trigger) or the eventing controller will not start.

Harwayne and others added 29 commits January 28, 2019 09:13
@Harwayne
Initial API outline for Broker.
d7ed39b
@Harwayne
Metadata is exported
080f5eb
@Harwayne
Initial Trigger API.
f20a2df
@Harwayne
Remove old comments.
163474d
@Harwayne
Register the types.
5f53e05
@Harwayne
Initial work on the Broker controller.
2f6a03f
@Harwayne
Initial work on the Trigger controller.
3ee0b8b
@Harwayne
Initial work on the new model and its corresponding broker controller.
da9fe36
@Harwayne
Initial work on the Trigger controller.
f8cca2e
@Harwayne
Add simple mains.
d7ebdcb
@Harwayne
Small fixes, still not working.
c5f7a83
@Harwayne
Add the Istio injection annotation.
054c10d
@Harwayne
Resolve subscriber in the Trigger controller.
942b979
@Harwayne
Standardize on 'Any'.
afd71af
@Harwayne
Make Broker and Trigger generational
7a1f69b
@Harwayne
Happy control path.
2be56bd
@Harwayne
TargetPort is 8080
10acfa3
@Harwayne
Watch channels.
2108d83
@Harwayne
Custom service account for filter (needs trigger watch).
6aa7086
@Harwayne
Increase logging in the Filter to debug level.
3cd236f
@Harwayne
Use the default channel provisioner.
be350a0
@nachocano
Adding filtering using k8s label selectors
0068232
@Harwayne
Watch namespaces and create a default Broker.
b4e2358
@nachocano
Merge remote-tracking branch 'broker/broker-new-model' into broker-ne…
3a9fd94 
…w-model
@nachocano
Updating trigger example with filters
5ca1b9f
@Harwayne
Broker changes cause the namespace watcher to reconcile.
bd53cda
@nachocano
Merge remote-tracking branch 'broker/broker-new-model' into broker-ne…
17889fb 
…w-model
@Harwayne
Merge branch 'master' into broker-new-model
582eb4c
@Harwayne
Move the Logging package import and format.
4f803a2
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019
@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 14, 2019
grantr
grantr reviewed Mar 14, 2019
View reviewed changes
Comment thread pkg/reconciler/v1alpha1/namespace/namespace.go Outdated
Comment thread pkg/reconciler/v1alpha1/namespace/namespace.go Outdated
Comment thread pkg/reconciler/v1alpha1/namespace/namespace.go
Harwayne and others added 6 commits March 14, 2019 15:02
@nachocano nachocano mentioned this pull request Mar 15, 2019
Merged
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Mar 15, 2019

Created knative/eventing-contrib#252 in eventing-sources to add broker read only permissions. It should be merged right after this one, otherwise sources won't be able to point to brokers.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Mar 15, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Mar 15, 2019

I got this to work after not reading the documentation and not creating the correct service account and role binding.

There is a bug in this code, the broker becomes ready when it does not have pods for the filter. The ingress pods come up and the filter pods never did.

I updated my chatbot demo to broker/trigger, here are the changes:

botless/slack#1
botless/commands#1
botless/parser#1

@Harwayne Harwayne mentioned this pull request Mar 18, 2019
Closed
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Mar 18, 2019

There is a bug in this code, the broker becomes ready when it does not have pods for the filter. The ingress pods come up and the filter pods never did.

I agree, #915.

Harwayne added 3 commits March 18, 2019 10:00
@Harwayne
Merge pull request #45 from Harwayne/broker-mark-failed
aef69fd 
Mark the Broker's Ingress and Filter status condidionts failed when they have failed.
@Harwayne
Do not DeepCopy() in Reconcile(), as controller-runtime already did i…
6abe39c 
…t for us.
@Harwayne
Merge pull request #46 from Harwayne/broker-no-deepcopy
0a60069 
Do not DeepCopy() in Reconcile(), as controller-runtime already did it for us
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Mar 18, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/broker_types.go Do not exist 76.9%
pkg/apis/eventing/v1alpha1/broker_validation.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/trigger_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/trigger_types.go Do not exist 77.8%
pkg/apis/eventing/v1alpha1/trigger_validation.go Do not exist 100.0%

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Mar 18, 2019

/lgtm

💪

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@knative-prow-robot knative-prow-robot merged commit 76603c8 into knative:master Mar 18, 2019
@n3wscott n3wscott mentioned this pull request Mar 18, 2019
Merged
@Harwayne Harwayne deleted the broker-new-model branch May 9, 2019 18:58
@grantr grantr mentioned this pull request Feb 7, 2020
Merged
6 tasks
matzew added a commit to matzew/eventing that referenced this pull request Sep 3, 2020
@matzew
🐳 updating linux container to have httpd-tools (knative#788)
9c2c35c 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scothis scothis Awaiting requested review from scothis

5 more reviewers

@grantr grantr grantr left review comments

@pmorie pmorie pmorie left review comments

@nachocano nachocano nachocano left review comments

@n3wscott n3wscott n3wscott left review comments

@akashrv akashrv akashrv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscott n3wscott

@akashrv akashrv

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.