adding n3wscott to approvers.

[n3wscott]

Updated: March 18

From [ROLES.md]
(https://github.com/knative/docs/blob/1b52510c44168a99efe6179c523cd68bdac1e07b/community/ROLES.md):

Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter

Earliest review: 2018-07-02, 259 days ago
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3An3wscott+sort%3Acreated-asc

Primary reviewer for at least 10 substantial PRs to the codebase

Reviewed 29 L, XL, or XXL PRs

• 12 L
• 3 XL
• 14 XXL

10 substantial examples:

1. Broker, Trigger, and Namespace Controllers #788 - 20+ comments

2. [WIP] Add NATS Streaming as a new bus implementation #491 - 15 comments

3. Defaultcontroller #843 - 12 comments

4. Create the in-memory-channel ClusterProvisioner #484 - 25+ comments

5. Adds Kafka Channel Provisioner Controllers #468 - 20+ comments

original submissions:

6. Add a new Channel CRD to the eventing group #430 - Majority reviewed.

7. Bus monitor polish #382 - Majority reviewed, this is a solid review.

8. add AWS SQS event source #328 - This is still in flight and has not been merged.

9. Enforce all code dirs have tests #453 - This is not yet merged (and may not be mergeable).

10. add support for Subsciption.replyTo property #325 - This was a split review, but I'd give credit.

Reviewed or merged at least 30 PRs to the codebase

Reviewed or merged 84 PRs
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3An3wscott

Nominated by an area lead with no objections from other leads

Current eventing lead is @vaikas-google.

/cc @evankanderson @vaikas-google @grantr @scothis

--

Past PRs:

1. Empty body stops ReplyTo. #467 - 7 comments
2. Generate unique, stable pubsub topic and subscription IDs #458 - 8 comments

---

Original 10:

1. Subscription Controller basics. #437
2. Add a new Channel CRD to the eventing group #430
3. Create new Subscription in pkg/apis/eventing as per the new spec. #421
4. Bus monitor polish #382
5. add AWS SQS event source #328
6. Run all controllers in the same process #313
7. Cluster scoped Bus #117
8. Enforce all code dirs have tests #453
9. add support for Subsciption.replyTo property #325
10. Add configmap for flow controller #324

[grantr]

👍 Scott's the top contributor by number of PRs merged. He's also made supporting contributions to https://github.com/knative/pkg that aren't counted here.

[evankanderson]

I took a look at the top 10 PRs. I think the reviews are a bit light, so I'm going to object at this time:

10 substantial examples:

#437

The majority of reviews on this PR came from grantr and mattmoor.

#430

Majority reviewed.

#421

This had a large number of reviewers, but I wouldn't consider Scott's a majority review.

#382

Majority reviewed, this is a solid review.

#328

This is still in flight and has not been merged.

#313

Small review (or @grantr produces very nice code...)

#117

This was majority reviewed by ericbottard and pmorie

#453

This is not yet merged (and may not be mergeable).

#325

This was a split review, but I'd give credit.

#324

This was majority reviewed by grantr.

[evankanderson]

To be clear, I'm just trying to apply our rules evenly -- and there's certainly space for strong contributors who mostly produce rather than review code (which would be the measure of "PRs merged"). I'm also happy to revisit this decision in a week or two if Scott starts being a code review monster. 🥇

[n3wscott]

/open

[n3wscott]

/reopen

[knative-prow-robot]

@n3wscott: Reopening this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[scothis]

@n3wscott can you add a comment about why you reopened this PR and summarize what has changed besides being "a week or two" later?

[n3wscott]

I had updated the description and added updated

[evankanderson]

It looks like 5 of the 10 review candidates haven't merged yet -- I agree that @n3wscott is prolific in writing code, but writing and reviewing are different skills. I think it's fine to have active contributors who aren't approvers, and I'm sure that Scott will end up reviewing more code.

[n3wscott]

Will reopen when those are submitted.

[n3wscott]

I'm back!

[evankanderson]

This looks like a solid collection of reviews. #843 in particular has some detailed feedback alongside @vaikas-google 's feedback. #484 also has some good feedback, particularly around managing Conditions.

[vaikas]

this diff looks odd because it looks like you're adding Harwayne (who's already in the head as well as removing inlined and scothis)

[vaikas]

not sure what view I was looking at...

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment