Skip to content

adding n3wscott to approvers. #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 2 commits into from
Mar 19, 2019
Merged

adding n3wscott to approvers. #465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e4cc9
adding n3wscott to approvers.
Sep 25, 2018
3172cb2
update.
Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ approvers:
- grantr
- Harwayne
Copy link
Copy Markdown
Contributor

@vaikas vaikas Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff looks odd because it looks like you're adding Harwayne (who's already in the head as well as removing inlined and scothis)

Copy link
Copy Markdown
Contributor

@vaikas vaikas Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what view I was looking at...

- vaikas-google
- n3wscott

# Reviewers are suggested from the reviewers list first, then the approvers
# list. To add reviewers while spreading the load among existing approvers,
Expand All @@ -12,6 +13,6 @@ reviewers:
- grantr
- Harwayne
- vaikas-google
# Add reviewers below
- n3wscott
# Add reviewers below
- matzew