Add OWNERS for the Kafka Channel#1030
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Holding until we get LGTMs from all new OWNERS and the Eventing Lead (@vaikas-google). |
| @@ -0,0 +1,13 @@ | |||
| # These OWNERS are in addition to the repo level OWNERS. | |||
There was a problem hiding this comment.
I can't find good documentation for this, but I think this is true based on the option being NoParentOwners.
There was a problem hiding this comment.
My understanding is that the comment is correct, subpath-owners are additive. You may have already seen this, but docs for the approval algorithm are at https://github.com/kubernetes/test-infra/tree/master/prow/plugins/approve/approvers.
|
/assign @bbrowning |
|
/assign @vaikas-google |
|
/close Closing in favor of #1033, which is more similar to knative/serving. |
|
@Harwayne: Closing this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Proposed Changes
Release Note