Skip to content

Add OWNERS for the Kafka Channel#1030

Closed
Harwayne wants to merge 1 commit into
knative:masterfrom
Harwayne:kafka-channel
Closed

Add OWNERS for the Kafka Channel#1030
Harwayne wants to merge 1 commit into
knative:masterfrom
Harwayne:kafka-channel

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Apr 5, 2019

Proposed Changes

  • Add OWNERS for the Kafka Channel, based on those who volunteered during the WG call.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/hold

Holding until we get LGTMs from all new OWNERS and the Eventing Lead (@vaikas-google).

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
Comment thread contrib/kafka/OWNERS
@@ -0,0 +1,13 @@
# These OWNERS are in addition to the repo level OWNERS.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find good documentation for this, but I think this is true based on the option being NoParentOwners.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the comment is correct, subpath-owners are additive. You may have already seen this, but docs for the approval algorithm are at https://github.com/kubernetes/test-infra/tree/master/prow/plugins/approve/approvers.

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/assign @bbrowning
/assign @matzew

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/assign @vaikas-google
/uncc @grantr
/uncc @evankanderson

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/close

Closing in favor of #1033, which is more similar to knative/serving.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@Harwayne: Closing this PR.

Details

In response to this:

/close

Closing in favor of #1033, which is more similar to knative/serving.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Harwayne Harwayne deleted the kafka-channel branch April 5, 2019 22:20
matzew added a commit to matzew/eventing that referenced this pull request Mar 26, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants