Skip to content

Add OWNERS for the Channel implementations#1033

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:channel-owners
Apr 25, 2019
Merged

Add OWNERS for the Channel implementations#1033
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:channel-owners

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Apr 5, 2019

Proposed Changes

  • Add OWNERS for the Channel implementations, based on those who volunteered during the WG call.

This will only be submitted once all of the following people have LGTM'ed it:

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2019
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/approve cancel
/hold

Holding until all those listed in the description have LGTM'ed.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/uncc @grantr
/uncc @n3wscott

/assign @vaikas-google
/assign @bbrowning
/assign @matzew
/assign @Abd4llA

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

LGTM (prow won't let me LGTM my own PR).

@matzew
Copy link
Copy Markdown
Member

matzew commented Apr 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2019
Comment thread OWNERS_ALIASES

kafka-approvers:
- bbrowning
- matzew
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 cool !

@bbrowning
Copy link
Copy Markdown
Contributor

/lgtm

@Harwayne
Copy link
Copy Markdown
Contributor Author

Ping @Abd4llA

@devguyio
Copy link
Copy Markdown
Contributor

/lgtm

@Harwayne
Copy link
Copy Markdown
Contributor Author

Ping @vaikas-google

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 25, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@knative-prow-robot knative-prow-robot merged commit 6c549cc into knative:master Apr 25, 2019
@Harwayne Harwayne deleted the channel-owners branch May 9, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants