Skip to content

Add OWNERS for the GCP-PubSub Channel, based on those who volunteered…#1032

Closed
Harwayne wants to merge 1 commit into
knative:masterfrom
Harwayne:gcp-owners
Closed

Add OWNERS for the GCP-PubSub Channel, based on those who volunteered…#1032
Harwayne wants to merge 1 commit into
knative:masterfrom
Harwayne:gcp-owners

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Apr 5, 2019

=## Proposed Changes

  • Add OWNERS for the GCP-PubSub Channel, based on those who volunteered during the WG call.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 5, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/hold

Holding until we get LGTMs from all new OWNERS and the Eventing Lead (@vaikas-google).

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/assign @vaikas-google
/uncc @n3wscott
/uncc @matzew

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 5, 2019

@Harwayne: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-integration-tests 6263bee link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Apr 5, 2019

/close
Closing in favor of #1033, which is more similar to knative/serving.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 5, 2019

@Harwayne: Closing this PR.

Details

In response to this:

/close
Closing in favor of #1033, which is more similar to knative/serving.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Harwayne Harwayne deleted the gcp-owners branch May 9, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Harwayne @knative-prow-robot @googlebot @vaikas