Skip to content

Fix for https://github.com/knative/eventing/issues/1109#1118

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
syedriko:fall_off_main
Apr 30, 2019
Merged

Fix for https://github.com/knative/eventing/issues/1109#1118
knative-prow-robot merged 3 commits into
knative:masterfrom
syedriko:fall_off_main

Conversation

@syedriko
Copy link
Copy Markdown
Contributor

@syedriko syedriko commented Apr 29, 2019

[BUG] eventing controller and source-controller fall off main() on shutdown signal

@syedriko
Fix for #1109
cfee74b 
[BUG] eventing controller and source-controller fall off main() on shutdown signal
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 29, 2019

Hi @syedriko. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@syedriko
Copy link
Copy Markdown
Contributor Author

syedriko commented Apr 29, 2019

/cc @vaikas-google

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Apr 29, 2019

/ok-to-test

Redo of #1110

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2019
grantr
grantr approved these changes Apr 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 29, 2019

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 29, 2019

hm, these are not there... Did they get removed already from serving? I'll look into this.
https://storage.googleapis.com/knative-nightly/serving/latest/istio-crds.yaml

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Apr 29, 2019

@n3wscott is looking at this. We need serving to upload this artifact to the latest nightly.

@grantr grantr mentioned this pull request Apr 29, 2019
Merged
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 29, 2019

/test pull-knative-eventing-integration-tests

1 similar comment
@syedriko
Copy link
Copy Markdown
Contributor Author

syedriko commented Apr 30, 2019

/test pull-knative-eventing-integration-tests

grantr
grantr approved these changes Apr 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b8a1d73 into knative:master Apr 30, 2019
@syedriko syedriko deleted the fall_off_main branch April 30, 2019 16:18
creydr added a commit to creydr/knative-eventing that referenced this pull request Mar 6, 2025
@openshift-cherrypick-robot @creydr
Run hack generate tool directly (knative#1118)
be7579a 
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@syedriko @knative-prow-robot @grantr @vaikas @googlebot