Skip to content

Fix for #1109 [BUG] eventing controller and source-controller fall off main() on shutdown signal #1110

Closed
syedriko wants to merge 1 commit into
knative:masterfrom
syedriko:fall_off_main
Closed

Fix for #1109 [BUG] eventing controller and source-controller fall off main() on shutdown signal #1110
syedriko wants to merge 1 commit into
knative:masterfrom
syedriko:fall_off_main

Conversation

@syedriko
Copy link
Copy Markdown
Contributor

@syedriko syedriko commented Apr 26, 2019

Fix for #1109 "[BUG] eventing controller and source-controller fall off main() on shutdown signal"

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 26, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 26, 2019

Hi @syedriko. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: syedriko
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: harwayne

If they are not already assigned, you can assign the PR to them by writing /assign @harwayne in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@syedriko
Copy link
Copy Markdown
Contributor Author

syedriko commented Apr 26, 2019

/cc @Harwayne

@syedriko syedriko changed the title https://github.com/knative/eventing/issues/1109 Fix for #1109 [BUG] eventing controller and source-controller fall off main() on shutdown signal Apr 26, 2019
@evankanderson
Copy link
Copy Markdown
Member

evankanderson commented Apr 26, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2019
@syedriko
Copy link
Copy Markdown
Contributor Author

syedriko commented Apr 26, 2019

the test failures look like #1077

/retest

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Apr 26, 2019

/cc @n3wscott

@syedriko
https://github.com/knative/eventing/issues/1109
41f5284 
[BUG] eventing controller and source-controller fall off main() on shutdown signal
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Apr 27, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/eventtype_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/eventtype_lifecycle.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/eventtype_validation.go Do not exist 95.7%
pkg/reconciler/eventtype/eventtype.go Do not exist 77.4%

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Apr 29, 2019

Could you please rebase as looks like there's bunch of unrelated changes in this PR. Thanks :)

@syedriko syedriko closed this Apr 29, 2019
@syedriko syedriko deleted the fall_off_main branch April 29, 2019 16:21
@grantr grantr mentioned this pull request Apr 29, 2019
Merged
lberk added a commit to lberk/eventing that referenced this pull request Feb 18, 2021
@lberk
Add diagnostic messages to mirror-upstream-branches.sh (knative#1110)
a3eb59a
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Mar 6, 2025
@dependabot @github-actions
[release-v1.17][gomod]: Bump the patch group across 1 directory with …
dfe105b 
…5 updates (knative#1110)

* [release-v1.17][gomod]: Bump the patch group across 1 directory with 5 updates

Bumps the patch group with 2 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver).


Updates `k8s.io/api` from 0.31.5 to 0.31.6
- [Commits](kubernetes/api@v0.31.5...v0.31.6)

Updates `k8s.io/apiextensions-apiserver` from 0.31.5 to 0.31.6
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.31.5...v0.31.6)

Updates `k8s.io/apimachinery` from 0.31.5 to 0.31.6
- [Commits](kubernetes/apimachinery@v0.31.5...v0.31.6)

Updates `k8s.io/apiserver` from 0.31.5 to 0.31.6
- [Commits](kubernetes/apiserver@v0.31.5...v0.31.6)

Updates `k8s.io/client-go` from 0.31.5 to 0.31.6
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.31.5...v0.31.6)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch
- dependency-name: k8s.io/apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Run make generate-release

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

@Harwayne Harwayne Awaiting requested review from Harwayne

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@syedriko @knative-prow-robot @evankanderson @grantr @knative-metrics-robot @vaikas @googlebot