Skip to content

golang format tools#1223

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor-sockpuppet:gotool-knative-eventingjnfg6-pod-965644
May 13, 2019
Merged

golang format tools#1223
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor-sockpuppet:gotool-knative-eventingjnfg6-pod-965644

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))
goimports -w $(find -name '*.go' | grep -v vendor)

Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
  `goimports -w $(find -name '*.go' | grep -v vendor)`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 13, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

/ok-to-test
/lgtm
/approve

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor-sockpuppet, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1alpha1/cron_job_types.go Do not exist 50.0%

@knative-prow-robot knative-prow-robot merged commit 7bdaf8d into knative:master May 13, 2019
chizhg pushed a commit to chizhg/eventing that referenced this pull request May 13, 2019
Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
  `goimports -w $(find -name '*.go' | grep -v vendor)`
matzew pushed a commit to matzew/eventing that referenced this pull request May 3, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Jun 2, 2021
mgencur referenced this pull request in openshift-knative/eventing Nov 14, 2022
* Rollback certificate algorithm changes (#1281)

* Allow URIs to be resolved without reconciler context (knative#2095) (#1274)

Co-authored-by: Mona Borham <mionaut@gmail.com>

* fix oom (#1266)

* silent noisy metrics (#1223)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Lukas Berk <lberk@redhat.com>
Co-authored-by: Mona Borham <mionaut@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Jun 18, 2025
…nces/release-v1.17

Update Konflux references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants