Destination in Parallel and Sequence#2095
Merged
Merged
Conversation
This reverts commit e85e7a8.
knative-prow-robot
added
do-not-merge/hold
nachocano
commented
Oct 25, 2019
| fe.Details = "only name, apiVersion and kind are supported fields" | ||
| return fe | ||
| }(), | ||
| // TODO check if destination should support DeprecatedNamespace and in its Ref. |
nachocano
commented
Oct 25, 2019
|
|
||
| type ParallelBranch struct { | ||
| // Filter is the expression guarding the branch | ||
| Filter *SubscriberSpec `json:"filter,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
SubscriberSpec has a *string as URI, as opposed to our Destination, which is *apis.URL. Check if this can break...
Contributor
Author
|
/assign @vaikas-google |
knative-prow-robot
added
the
area/test-and-release
|
The following is the coverage report on the affected files.
|
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
nachocano
changed the title
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
May 18, 2021
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
May 18, 2021
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
May 18, 2021
…1274) Co-authored-by: Mona Borham <mionaut@gmail.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
May 18, 2021
…1275) Co-authored-by: Mona Borham <mionaut@gmail.com>
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Jun 2, 2021
…native#1274) Co-authored-by: Mona Borham <mionaut@gmail.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Jun 2, 2021
* Rollback certificate algorithm changes (#1281) * Allow URIs to be resolved without reconciler context (knative#2095) (#1274) Co-authored-by: Mona Borham <mionaut@gmail.com> * fix oom (#1266) * silent noisy metrics (#1223) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Lukas Berk <lberk@redhat.com> Co-authored-by: Mona Borham <mionaut@gmail.com> Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note
/hold until #2094 gets merged and we rebase