Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup#1266

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
skonto:fix_oom_open
May 11, 2021
Merged

[RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup#1266
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
skonto:fix_oom_open

Conversation

@skonto
Copy link
Copy Markdown

@skonto skonto commented May 11, 2021

Since we cant get knative/pkg#2102 in let's fix it here.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@skonto skonto changed the title fix oom [RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup May 11, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Copy Markdown
Author

skonto commented May 11, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit aead04e into openshift:release-v0.21.0 May 11, 2021
openshift-merge-robot pushed a commit that referenced this pull request Jun 2, 2021
* Rollback certificate algorithm changes (#1281)

* Allow URIs to be resolved without reconciler context (knative#2095) (#1274)

Co-authored-by: Mona Borham <mionaut@gmail.com>

* fix oom (#1266)

* silent noisy metrics (#1223)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Lukas Berk <lberk@redhat.com>
Co-authored-by: Mona Borham <mionaut@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants