Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-0.21][Backport] Unregister views to avoid slow oom issue during meter cleanup#764

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
skonto:fix_oom_21
May 18, 2021
Merged

[RELEASE-0.21][Backport] Unregister views to avoid slow oom issue during meter cleanup#764
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
skonto:fix_oom_21

Conversation

@skonto
Copy link
Copy Markdown

@skonto skonto commented May 18, 2021 •
edited
Loading

Corresponding PR for Serving as in here: openshift/knative-eventing#1266
/cc @markusthoemmes @maschmid

@openshift-ci openshift-ci Bot requested review from alanfx and arilivigni May 18, 2021 11:18
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@skonto skonto changed the title [RELEASE-0.21] Unregister views to avoid slow oom issue during meter cleanup [RELEASE-0.21][Backport] Unregister views to avoid slow oom issue during meter cleanup May 18, 2021
markusthoemmes
markusthoemmes approved these changes May 18, 2021
View reviewed changes
Copy link
Copy Markdown

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [markusthoemmes,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maschmid
Copy link
Copy Markdown

maschmid commented May 18, 2021

Should we use --branch release-1.15 or something in https://github.com/openshift/knative-serving/blob/release-v0.21.0/openshift/e2e-common.sh#L209 ?

@skonto
Copy link
Copy Markdown
Author

skonto commented May 18, 2021

/retest

@maschmid
Copy link
Copy Markdown

maschmid commented May 18, 2021

We can try merging #765 first.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1128303 into openshift:release-v0.21.0 May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@arilivigni arilivigni Awaiting requested review from arilivigni

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skonto @maschmid @openshift-bot @markusthoemmes @openshift-merge-robot