This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[SRVKS-720] Mute noisy metrics controller & webhook#1223
Merged
openshift-merge-robot merged 1 commit intoApr 28, 2021
Conversation
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@skonto do we need this backport to the 0.22 release too? and perhaps for 0.20? For a potential 1.14.1 release ? |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 2, 2021
* Rollback certificate algorithm changes (#1281) * Allow URIs to be resolved without reconciler context (knative#2095) (#1274) Co-authored-by: Mona Borham <mionaut@gmail.com> * fix oom (#1266) * silent noisy metrics (#1223) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Lukas Berk <lberk@redhat.com> Co-authored-by: Mona Borham <mionaut@gmail.com> Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
This was referenced Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutdown these noisy metrics (they are in TODO status because they are useful), however I spotted a worse issue. Check my comment here.
/cc @matzew @schmidtd.