Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[SRVKS-720] Mute noisy metrics controller & webhook #1223

Merged
openshift-merge-robot merged 1 commit into from
Apr 28, 2021
Merged

[SRVKS-720] Mute noisy metrics controller & webhook #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vendor/knative.dev/pkg/controller/stats_reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func (r *reporter) ReportReconcile(duration time.Duration, success string, key t
return err
}

metrics.RecordBatch(ctx, reconcileCountStat.M(1),
reconcileLatencyStat.M(duration.Milliseconds()))
// TODO skonto: fix latency histogram
metrics.RecordBatch(ctx, reconcileCountStat.M(1))
return nil
}
5 changes: 2 additions & 3 deletions vendor/knative.dev/pkg/webhook/stats_reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,8 @@ func (r *reporter) ReportRequest(req *admissionv1.AdmissionRequest, resp *admiss
return err
}

metrics.RecordBatch(ctx, requestCountM.M(1),
// Convert time.Duration in nanoseconds to milliseconds
responseTimeInMsecM.M(float64(d.Milliseconds())))
// TODO skonto: fix latency histogram
metrics.Record(ctx, requestCountM.M(1))
return nil
}

Expand Down