Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[Backport] Allow URIs to be resolved without reconciler context (#2095)#1274

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
lberk:backport-addressable-context-fix
May 18, 2021
Merged

[Backport] Allow URIs to be resolved without reconciler context (#2095)#1274
openshift-merge-robot merged 1 commit into
openshift:release-v0.21.0from
lberk:backport-addressable-context-fix

Conversation

@lberk
Copy link
Copy Markdown
Member

@lberk lberk commented May 18, 2021

Seems like this fixes SRVKE-780

@openshift-ci openshift-ci Bot requested review from alanfx and devguyio May 18, 2021 14:07
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member

matzew commented May 18, 2021

Thanks @lberk this is for 0.21

Mind doing the same for 0.22 ? 🙏

@lberk
Copy link
Copy Markdown
Member Author

lberk commented May 18, 2021

@matzew done in #1275

@openshift-merge-robot openshift-merge-robot merged commit 3b8745c into openshift:release-v0.21.0 May 18, 2021
openshift-merge-robot pushed a commit that referenced this pull request Jun 2, 2021
* Rollback certificate algorithm changes (#1281)

* Allow URIs to be resolved without reconciler context (knative#2095) (#1274)

Co-authored-by: Mona Borham <mionaut@gmail.com>

* fix oom (#1266)

* silent noisy metrics (#1223)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Lukas Berk <lberk@redhat.com>
Co-authored-by: Mona Borham <mionaut@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants