Skip to content

Destination in Sequence#2094

Closed
nachocano wants to merge 16 commits into
knative:masterfrom
nachocano:sequence
Closed

Destination in Sequence#2094
nachocano wants to merge 16 commits into
knative:masterfrom
nachocano:sequence

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Oct 25, 2019 •
edited
Loading

Proposed Changes

  • Adding Destination in Sequence replies.

Release Note

Sequence replies are now Destinations.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 25, 2019
nachocano
nachocano commented Oct 25, 2019
View reviewed changes
Comment thread pkg/apis/messaging/v1alpha1/sequence_validation_test.go
fe.Details = "only name, apiVersion and kind are supported fields"
return fe
}(),
// TODO current destination ref allows setting the namespace, thus this fails.
Copy link
Copy Markdown
Contributor Author

@nachocano nachocano Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

we have a DeprecatedNamespace in Destination, is that correct? I thought we weren't supporting namespaces in ObjectRef..
If that is the case, the Ref in Destination should actually validate that... as done here

Copy link
Copy Markdown
Contributor Author

@nachocano nachocano Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel, it seems that we will let this through

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Oct 25, 2019

/assign @vaikas-google
/assign @Harwayne to confirm the concern in the hold

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Oct 25, 2019

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1alpha1/sequence_validation.go 94.4% 94.1% -0.3

@nachocano nachocano mentioned this pull request Oct 25, 2019
Merged
vaikas
vaikas reviewed Oct 25, 2019
View reviewed changes
Comment thread pkg/apis/messaging/v1alpha1/sequence_validation_test.go
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 25, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
Harwayne
Harwayne reviewed Oct 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, but I think it needs to also:

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Oct 25, 2019

Looks great so far, but I think it needs to also:

Adam, this changes actually got in with #2095... The parallel branch was forked from here. In both I didn't do this... Let me add it and will submit a new PR... Might be ready by Monday. Will close this one...

@nachocano nachocano closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@n3wscott n3wscott Awaiting requested review from n3wscott

2 more reviewers

@Harwayne Harwayne Harwayne left review comments

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nachocano @knative-metrics-robot @vaikas @knative-prow-robot @Harwayne @googlebot