Pipeline Implementation#1239
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vaikas-google If you want I can take an initial stab at the reconciler. LMK. |
|
I wired a pipeline like this (using IMC (After my fix that got merged earlier today)), and the following pipeline worked, verified the data flew through the pipeline:
|
|
If it looks good, I'll work on the validation / docs after this, but given the shift in time, unless there's something major that can't be fixed in a followup, I'd like to get this merged so that I don't have to keep rebasing :) |
|
/lgtm |
|
/hold I want to review the changes. |
| if address == nil { | ||
| address := c.Status.AddressStatus.Address | ||
| if address != nil { | ||
| ps.ChannelStatuses[i].ReadyCondition = apis.Condition{Type: apis.ConditionReady, Status: corev1.ConditionTrue} |
There was a problem hiding this comment.
This isn't quite accurate, a Channelable may be addressable but not ready.
For now, I'm OK with a TODO.
There was a problem hiding this comment.
Yes, I had a TODO there (and dropped it somewhere along the way), and I think we need to change Channelable a little bit, because it doesn't include anything useful besides this.
|
The following is the coverage report on pkg/.
|
Fixes #1067
Proposed Changes
Release Note