Skip to content

adding lionelvillard to approvers#2314

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:approver-lionelvillard
Dec 12, 2019
Merged

adding lionelvillard to approvers#2314
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:approver-lionelvillard

Conversation

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 12, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2019
@nachocano
Copy link
Copy Markdown
Contributor

/lgtm
Well deserved @lionelvillard !!!

I'll let someone else to approve
Remember to add yourself to eventing-contrib approvers as well...

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Dec 12, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@knative-prow-robot knative-prow-robot merged commit c5201c1 into knative:master Dec 12, 2019
@matzew
Copy link
Copy Markdown
Member

matzew commented Dec 13, 2019

LGTM ! :-)

@lionelvillard lionelvillard deleted the approver-lionelvillard branch August 28, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants