Skip to content

ApiServerSource updates its receive adapter, if needed.#1576

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:apiserversource-update
Jul 26, 2019
Merged

ApiServerSource updates its receive adapter, if needed.#1576
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:apiserversource-update

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

Proposed Changes

  • ApiServerSource updates its receive adapter, if needed.

Release Note

ApiServerSources will update existing receive adapters if their arguments have 
changed. This may cause changes made in the past to suddenly take effect. 

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 26, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserversource/apiserversource.go 67.7% 77.9% 10.2

@lionelvillard
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@knative-prow-robot knative-prow-robot merged commit 210021e into knative:master Jul 26, 2019
@Harwayne Harwayne deleted the apiserversource-update branch July 29, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants