Skip to content

golang format tools#1282

Closed
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:gotool-knative-eventingbd6bq-pod-58c469
Closed

golang format tools#1282
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:gotool-knative-eventingbd6bq-pod-58c469

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))
goimports -w $(find -name '*.go' | grep -v vendor)

Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
  `goimports -w $(find -name '*.go' | grep -v vendor)`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 28, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattmoor-sockpuppet
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: adrcunha

If they are not already assigned, you can assign the PR to them by writing /assign @adrcunha in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor closed this May 28, 2019
skonto pushed a commit to skonto/eventing that referenced this pull request Jun 4, 2021
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants