Skip to content

Format markdown#1281

Closed
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventingw7wph-pod-167f81
Closed

Format markdown#1281
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:prettier-knative-eventingw7wph-pod-167f81

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

Produced via: prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)

Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 28, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattmoor-sockpuppet
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jessiezcc

If they are not already assigned, you can assign the PR to them by writing /assign @jessiezcc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor closed this May 28, 2019
matzew pushed a commit to matzew/eventing that referenced this pull request May 25, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request May 25, 2021
cardil pushed a commit to cardil/knative-eventing that referenced this pull request May 25, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Jun 2, 2021
matzew added a commit to matzew/eventing that referenced this pull request Jun 4, 2021
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
skonto pushed a commit to skonto/eventing that referenced this pull request Jun 4, 2021
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
matzew added a commit to matzew/eventing that referenced this pull request Sep 3, 2021
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
devguyio pushed a commit to devguyio/eventing that referenced this pull request Sep 3, 2021
* Rollback certificate algorithm changes (knative#1281) (knative#1283)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>

* mute noisy metrics

* [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
devguyio added a commit to devguyio/eventing that referenced this pull request Sep 17, 2021
* add patch of missing versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Patch 0.23 with missing API versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* remove the patch, it's not needed in other versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Using pre-built image from OCP registry (#2)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Apply ko publish patch to here ... (#3)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* One more thing.... (#4)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add logs to understand rekt progress

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Adding back vendor patches (#5)

* Rollback certificate algorithm changes (knative#1281) (knative#1283)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>

* mute noisy metrics

* [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
mgencur referenced this pull request in openshift-knative/eventing Nov 14, 2022
* Rollback certificate algorithm changes (#1281)

* Allow URIs to be resolved without reconciler context (knative#2095) (#1274)

Co-authored-by: Mona Borham <mionaut@gmail.com>

* fix oom (#1266)

* silent noisy metrics (#1223)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Lukas Berk <lberk@redhat.com>
Co-authored-by: Mona Borham <mionaut@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
creydr added a commit to creydr/knative-eventing that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants