Skip to content

Natss CRD Controller UT + Dispatcher Tracing#1361

Merged
knative-prow-robot merged 12 commits into
knative:masterfrom
nachocano:natss-ut
Jun 7, 2019
Merged

Natss CRD Controller UT + Dispatcher Tracing#1361
knative-prow-robot merged 12 commits into
knative:masterfrom
nachocano:natss-ut

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Jun 6, 2019

Helps with #1217

Proposed Changes

  • Adding UT for NATSS controller.
  • Needed a refactor to have our own reconciler, options, statsreporter, test factory, etc.
  • Adding Zipkin tracing

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 6, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 6, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @vaikas-google
/assign @n3wscott

@nachocano nachocano changed the title Natss CRD Controller UT Natss CRD Controller UT + Dispatcher Tracing Jun 6, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @Harwayne in case you have some free cycles

Comment thread contrib/natss/pkg/reconciler/reconciler.go Outdated
Comment thread contrib/natss/pkg/reconciler/stats_reporter.go Outdated
Comment thread contrib/natss/pkg/reconciler/testing/natsschannel.go Outdated
Comment thread contrib/natss/pkg/reconciler/testing/natsschannel.go Outdated
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 7, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@knative-prow-robot knative-prow-robot merged commit 51460f3 into knative:master Jun 7, 2019
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/natss/pkg/reconciler/controller/natsschannel.go Do not exist 80.6%

matzew pushed a commit to matzew/eventing that referenced this pull request Aug 20, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 20, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 20, 2021
markusthoemmes added a commit to markusthoemmes/knative-eventing that referenced this pull request Aug 23, 2021
… (knative#1366)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
mgencur pushed a commit to mgencur/eventing that referenced this pull request Aug 27, 2021
… (knative#1365)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 3, 2021
devguyio pushed a commit to devguyio/eventing that referenced this pull request Sep 3, 2021
* Rollback certificate algorithm changes (knative#1281) (knative#1283)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>

* mute noisy metrics

* [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
devguyio added a commit to devguyio/eventing that referenced this pull request Sep 17, 2021
* add patch of missing versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Patch 0.23 with missing API versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* remove the patch, it's not needed in other versions

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Using pre-built image from OCP registry (#2)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Apply ko publish patch to here ... (#3)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* One more thing.... (#4)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add logs to understand rekt progress

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Adding back vendor patches (#5)

* Rollback certificate algorithm changes (knative#1281) (knative#1283)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>

* mute noisy metrics

* [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>

Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
markusthoemmes added a commit to markusthoemmes/knative-eventing that referenced this pull request Sep 22, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 24, 2021
…ative#1415)

* Revert "[SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361) (knative#1366)"

This reverts commit ae3df83.

* upgrade to latest dependencies (knative#5699)

bumping knative.dev/pkg 21eb4c1...844a6bc:
  > 844a6bc [release-0.25] allow unknown metadata fields (# 2254)
  > 5bed044 Drop redundant pointers and decoders (# 2259)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: knative-automation <automation@knative.team>
matzew added a commit to matzew/eventing that referenced this pull request Oct 4, 2021
matzew added a commit to matzew/eventing that referenced this pull request Oct 4, 2021
* Revert "[SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361) (knative#1365)"

This reverts commit cef96eb.

* upgrade to latest dependencies (knative#5707)

bumping knative.dev/pkg dd0db4b...953af01:
  > 953af01 [release-0.24] allow unknown metadata fields (# 2255)
  > 03e7ca5 Drop redundant pointers and decoders (# 2260)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: knative-automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants