Skip to content

Add K8s Services to the addressable resolver role.#1365

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:service-resolver
Jun 7, 2019
Merged

Add K8s Services to the addressable resolver role.#1365
knative-prow-robot merged 1 commit into
knative:masterfrom
Harwayne:service-resolver

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Jun 6, 2019

Proposed Changes

  • Add K8s Services to the addressable resolver role.

Release Note

The addressable-resolver role now includes Kubernetes Services.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 6, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 7, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Harwayne,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7742ac2 into knative:master Jun 7, 2019
@Harwayne Harwayne deleted the service-resolver branch June 24, 2019 16:39
mgencur pushed a commit to mgencur/eventing that referenced this pull request Aug 27, 2021
… (knative#1365)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
matzew added a commit to matzew/eventing that referenced this pull request Oct 4, 2021
matzew added a commit to matzew/eventing that referenced this pull request Oct 4, 2021
* Revert "[SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361) (knative#1365)"

This reverts commit cef96eb.

* upgrade to latest dependencies (knative#5707)

bumping knative.dev/pkg dd0db4b...953af01:
  > 953af01 [release-0.24] allow unknown metadata fields (# 2255)
  > 03e7ca5 Drop redundant pointers and decoders (# 2260)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: knative-automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants