Skip to content

Channel Deprecation Condition#1366

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:channel-deprecated
Jun 7, 2019
Merged

Channel Deprecation Condition#1366
knative-prow-robot merged 1 commit into
knative:masterfrom
nachocano:channel-deprecated

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Helps with Channel CRDs

Proposed Changes

  • Adding a condition to the Channel provisioners saying that we are deprecating them, and that they will be removed in 0.8.

Release Note

Channel provisioners (kafka, natss, gcp-pubsub and in-memory) are deprecated in 0.7. Will be removed in 0.8

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 7, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @akashrv
/assign @vaikas-google
/assign @grantr

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/gcppubsub/pkg/controller/channel/reconcile.go 96.3% 96.4% 0.0
contrib/kafka/pkg/controller/channel/reconcile.go 81.7% 81.9% 0.2
contrib/natss/pkg/controller/channel/reconcile.go 78.0% 78.4% 0.4
pkg/provisioners/inmemory/channel/reconcile.go 95.7% 95.8% 0.1

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 7, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@knative-prow-robot knative-prow-robot merged commit d94ce36 into knative:master Jun 7, 2019
markusthoemmes added a commit to markusthoemmes/knative-eventing that referenced this pull request Aug 23, 2021
… (knative#1366)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
markusthoemmes added a commit to markusthoemmes/knative-eventing that referenced this pull request Sep 22, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 24, 2021
…ative#1415)

* Revert "[SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361) (knative#1366)"

This reverts commit ae3df83.

* upgrade to latest dependencies (knative#5699)

bumping knative.dev/pkg 21eb4c1...844a6bc:
  > 844a6bc [release-0.25] allow unknown metadata fields (# 2254)
  > 5bed044 Drop redundant pointers and decoders (# 2259)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: knative-automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants