Replace "Elafros" with "Knative Serving".#131
Replace "Elafros" with "Knative Serving".#131google-prow-robot merged 2 commits intoknative:masterfrom adrcunha:ela-to-knative
Conversation
google-prow-robot
added
the
size/XS
| Generation int64 `json:"generation,omitempty"` | ||
|
|
||
| // Traffic specifies how to distribute traffic over a collection of Elafros Revisions and Configurations. | ||
| // Traffic specifies how to distribute traffic over a collection of Knative Serving Revisions and Configurations. |
There was a problem hiding this comment.
Did this change due to a vendor update? I would have expected the Gopkg files to change if so.
There was a problem hiding this comment.
No, I changed the file manually since it's just a comment.
There was a problem hiding this comment.
Bumping the vendor dep would pull this comment in - there appear to be many other changes that have been made to the route_types.go file in build/master
There was a problem hiding this comment.
I prefer not touching things that I don't fully understand. :)
There was a problem hiding this comment.
In that event - best not to change file in /vendor in this PR. Files in /vendor should be changed by dependency bumps. The text is already changed in the repo where this file 'lives' and will come in in the next dep bump.
There was a problem hiding this comment.
I'll create a new PR to update this dependency. IMO we should be tracking knative/serving master.
There was a problem hiding this comment.
Thanks, @grantr . Now this PR touches only the markdown file.
|
/assign @grantr |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
5 participants
No description provided.