Update knative/serving to latest master#138
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 2, 2018
Merged
Conversation
The version specified in the constraint was several weeks old with significant changes since then.
google-prow-robot
added
the
size/XL
grantr
force-pushed
the
update-to-latest-serving
branch
from
717c465 to
b25b5f8
Compare
Member
|
/lgtm I think it might make me happy if we could avoid needing to vendor all of this, but I don't know what that would involve. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version specified in the constraint was several weeks old with significant changes since then. See https://github.com/knative/eventing/pull/131/files#diff-41a493c003811784b6f2bad6a191117a for context on why this change was made now.
I didn't remove the constraint in this PR, but I think it would be a good idea to remove it until we have tagged releases and compatibility guarantees. Tracking master will allow breakages to be caught more quickly with a smaller delta to a known good state. @pmorie @mattmoor@vaikas-google may have thoughts on this.