Use latest knative/serving#149
Merged
google-prow-robot merged 2 commits intoknative:masterfrom Jul 9, 2018
scothis:bump-serving
Merged
Use latest knative/serving#149google-prow-robot merged 2 commits intoknative:masterfrom scothis:bump-serving
google-prow-robot merged 2 commits intoknative:masterfrom
scothis:bump-serving
Conversation
Now that there is an istio/v1alpha3 client in serving, we can drop our client and share serving's client. Refs #93 (comment)
google-prow-robot
added
the
size/XXL
Member
|
This LGTM, but I'd like @tcnghia to confirm that there aren't any hot fixes coming :) |
Member
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, scothis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
Contributor
|
After #138 goes in this will need to be rebased |
Member
|
Oops, I just let #138 in. I should have kept it out in favor of this. |
Contributor
|
Maybe best to close this and create a new update PR when @tcnghia thinks we're ready. |
Member
|
/lgtm |
benmoss
added a commit
to benmoss/eventing
that referenced
this pull request
Nov 10, 2021
Float the ko dependency, 0.6.0 is quite old and I think ko is stable enough now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that there is an istio/v1alpha3 client in serving, we can drop our
client and share serving's client.
Refs #93 (comment)
/assign @mattmoor