Update to Istio v1alpha3 types#93
Update to Istio v1alpha3 types#93google-prow-robot merged 3 commits intoknative:masterfrom scothis:istio-v1alpha3
Conversation
google-prow-robot
added
the
size/XXL
RouteRule -> VirtualService Ingress -> Gateway
|
All ingress has been removed for channels which means we can start using VirtualService now. I moved the istio v1alpha3 types from @tcnghia's branch into this repo. Once knative/serving#1228 merges we can switch over. After this PR merges, we can send events to channels by making a request to the channel's service. |
scothis
changed the title
vaikas
left a comment
vaikas
left a comment
There was a problem hiding this comment.
Just one question, otherwise lgtm.
| func NewController( | ||
| kubeclientset kubernetes.Interface, | ||
| feedsclientset clientset.Interface, | ||
| servingclientset servingclientset.Interface, |
There was a problem hiding this comment.
I see you added this here, but I can't seem to find where it's used?
There was a problem hiding this comment.
dead code from the client being in the serving repo, will remove. We'll need to put it back when switching back to the serving repo client.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: scothis, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
Now that there is an istio/v1alpha3 client in serving, we can drop our client and share serving's client. Refs #93 (comment)
…et already (knative#6671) (knative#93) Fixes knative#6539 In case a Subscription with a `.spec.subscriber.ref` pointing to a service in another namespace, the Subscription will not become ready because it is trying to find the service on the subscription's namespace (see knative#6539). Same happens with a subscriptions `.spec.reply.ref`. This PR addresses it and only uses the namespace of the Subscription, if no namespace was given for the subscriber/reply. ## Proposed Changes * 🐛 Populate a subscriptions subscriber & reply namespace field with the Subscriptions namespace only in case it is not set ### Pre-review Checklist - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** ```release-note ``` **How to verify** 1. Install a eventing with this patch 2. Create a sequence with steps and a reply in different namespaces (e.g. https://gist.github.com/creydr/57235f35b03ab8f1285eee0a64350576) 3. Check that the subscriptions and sequence becomes ready Signed-off-by: Christoph Stäbler <cstabler@redhat.com> (cherry picked from commit bd67450)
4 participants
Proposed Changes
RouteRule->VirtualServiceIngress->/dev/nullChannels will no longer be exposed outside of the cluster.
The Istio client copies the types from knative/serving#1228. Once that PR merges, we should use the client from the serving repo and remove the client in eventing
Refs knative/serving#1228