Skip to content

Add e2e test for InMemoryChannel#1340

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
chizhg:AddE2ETestForInMemoryCRDChannel
Jun 7, 2019
Merged

Add e2e test for InMemoryChannel#1340
knative-prow-robot merged 2 commits into
knative:masterfrom
chizhg:AddE2ETestForInMemoryCRDChannel

Conversation

@chizhg
Copy link
Copy Markdown
Contributor

@chizhg chizhg commented Jun 4, 2019 •
edited
Loading

Proposed Changes

  • Add e2e test for InMemoryChannel.

Release Note

NONE

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 4, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 4, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2019
@chizhg chizhg changed the title [WIP]Add e2e test for InMemoryChannel Add e2e test for InMemoryChannel Jun 5, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 5, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 5, 2019

/uncc @matzew
/uncc @bbrowning
/uncc @steuhs
/cc @nachocano

@knative-prow-robot knative-prow-robot requested review from nachocano and removed request for bbrowning, matzew and steuhs June 5, 2019 21:15
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resource_getters.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/base/resources/messaging.go Outdated
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/common/config.go
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/common/creation.go
nachocano
nachocano reviewed Jun 5, 2019
View reviewed changes
Comment thread test/common/creation.go Outdated
@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 5, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 5, 2019

/retest

@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Jun 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 5, 2019

/hold
Hold until InMemoryChannel is fully functional.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2019
@akashrv
Copy link
Copy Markdown
Contributor

akashrv commented Jun 6, 2019

/retest

@akashrv
Copy link
Copy Markdown
Contributor

akashrv commented Jun 6, 2019

@Fredy-Z Ville just fixed the inmemory channel with subscribablestatus. It should be fully functional now. Could you verify and unblock this PR?

@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 6, 2019

/hold cancel
/cc @grantr
Please take a look, thanks :-)

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2019
@knative-prow-robot knative-prow-robot requested a review from grantr June 6, 2019 18:31
@chizhg chizhg mentioned this pull request Jun 6, 2019
Merged
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Jun 7, 2019

/assign @vaikas-google might be able to help with the approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 7, 2019

@nachocano: GitHub didn't allow me to assign the following users: able, to, the, might, be, help, with, approve.

Note that only knative members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @vaikas-google might be able to help with the approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chizhg chizhg force-pushed the AddE2ETestForInMemoryCRDChannel branch from 5ac6650 to 1f756ac Compare June 7, 2019 07:05
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@chizhg chizhg force-pushed the AddE2ETestForInMemoryCRDChannel branch 2 times, most recently from 3245421 to 6e84562 Compare June 7, 2019 07:09
@chizhg chizhg force-pushed the AddE2ETestForInMemoryCRDChannel branch from 6e84562 to 41d7b24 Compare June 7, 2019 07:11
@chizhg
Copy link
Copy Markdown
Contributor Author

chizhg commented Jun 7, 2019

I did a rebase to remove all the junk commit logs, nothing else was changed.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 7, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fredy-Z, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@knative-prow-robot knative-prow-robot merged commit ccea0c0 into knative:master Jun 7, 2019
@nachocano nachocano mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

1 more reviewer

@nachocano nachocano nachocano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nachocano nachocano

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chizhg @nachocano @akashrv @knative-prow-robot @vaikas @googlebot