Skip to content

Removing In-Memory CCP binaries and config, and updating release script#1484

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
matzew:remove_in-memory_ccp
Aug 7, 2019
Merged

Removing In-Memory CCP binaries and config, and updating release script#1484
knative-prow-robot merged 2 commits into
knative:masterfrom
matzew:remove_in-memory_ccp

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 28, 2019

Fixes #

Proposed Changes

  • removal of inmen ccp binary, config

Release Note

removing the deprecated In Memory Cluster Channel Provisioner

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 28, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jun 28, 2019
@matzew matzew changed the title Removing In-Memory CCP binaries and config, and updating release script WIP: Removing In-Memory CCP binaries and config, and updating release script Jun 28, 2019
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019
@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Jul 1, 2019

/hold
ClusterChannelProvisoners cannot be removed before #1343 is solved, since the default broker created from namespace annotation still relies on the In-Memory CCP, and other CCPs as well if the default CCP is changed through the config map.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Jul 29, 2019

Default Channel has been supported - #1560, and all provisioner related e2e tests have been removed.

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2019
@matzew matzew force-pushed the remove_in-memory_ccp branch from caa8a85 to fea251b Compare July 31, 2019 13:55
@matzew matzew changed the title WIP: Removing In-Memory CCP binaries and config, and updating release script Removing In-Memory CCP binaries and config, and updating release script Jul 31, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2019
@matzew matzew force-pushed the remove_in-memory_ccp branch from fea251b to ade0587 Compare August 6, 2019 15:13
@matzew matzew force-pushed the remove_in-memory_ccp branch from ade0587 to 57f5c59 Compare August 7, 2019 09:05
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Aug 7, 2019

@Harwayne @n3wscott @vaikas-google @Fredy-Z I've updated this PR to remove the In-Mem. CCP binaries, their config and updated the release script!

Harwayne
Harwayne reviewed Aug 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@knative-prow-robot knative-prow-robot merged commit fffb8d0 into knative:master Aug 7, 2019
@matzew matzew mentioned this pull request Aug 7, 2019
Closed
This was referenced Aug 8, 2019
Closed
Closed
@matzew matzew mentioned this pull request Sep 6, 2019
Closed
devguyio pushed a commit to devguyio/eventing that referenced this pull request Nov 18, 2021
@matzew
Merge pull request knative#1484 from matzew/remove_ansible_main
36dc191 
Remove ansible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dushyanthsc dushyanthsc Awaiting requested review from dushyanthsc

@grantr grantr Awaiting requested review from grantr

1 more reviewer

@Harwayne Harwayne Harwayne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matzew @chizhg @knative-prow-robot @Harwayne @googlebot