Skip to content

Remove role & rolebinding configuration for in-memory-channel-dispatcher#1785

Closed
sravankumar777 wants to merge 1 commit into
knative:masterfrom
sravankumar777:remove-roles-configuration-in-memory-channel-dispatcher
Closed

Remove role & rolebinding configuration for in-memory-channel-dispatcher#1785
sravankumar777 wants to merge 1 commit into
knative:masterfrom
sravankumar777:remove-roles-configuration-in-memory-channel-dispatcher

Conversation

@sravankumar777
Copy link
Copy Markdown
Contributor

Fixes #
Duplicated role & rolebinding configuration for in-memory-channel-dispatcher.

Proposed Changes

During the deployment of knative-eventing with release yaml of v0.8.0, deployment file has ClusterRole & Role information duplicated for in-memory-channel-dispatcher.

apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: in-memory-channel-dispatcher
namespace: knative-eventing
labels:
eventing.knative.dev/release: devel
rules:
- apiGroups:
- ""
resources:
- "configmaps"
verbs:
- get
- list
- watch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: in-memory-channel-dispatcher
namespace: knative-eventing
labels:
eventing.knative.dev/release: devel
subjects:
- kind: ServiceAccount
name: in-memory-channel-dispatcher
namespace: knative-eventing
roleRef:
kind: Role
name: in-memory-channel-dispatcher
apiGroup: rbac.authorization.k8s.io

Release Note

Upcoming release for knative-eventing should be included with **in-memory-channel-dispatcher** cluster role & cluster role binding. 

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Sep 1, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sravankumar777
To complete the pull request process, please assign n3wscott
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @sravankumar777. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2019
@sravankumar777
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@sravankumar777
Copy link
Copy Markdown
Contributor Author

@googlebot I fixed it.

@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 6, 2019

@sravankumar777 this file is gone, since:

#1484

@matzew
Copy link
Copy Markdown
Member

matzew commented Sep 6, 2019

/close

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@matzew: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 11, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 11, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 12, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 18, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 22, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 22, 2022
…native#1807)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 17, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
mgencur referenced this pull request in openshift-knative/eventing Nov 14, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
mgencur referenced this pull request in openshift-knative/eventing Nov 14, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Indicates the PR's author has not signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants