Skip to content

Auto-update dependencies#1518

Closed
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:update-deps-knative-eventing-ssb7c-pod-5b5e05
Closed

Auto-update dependencies#1518
mattmoor-sockpuppet wants to merge 1 commit into
knative:masterfrom
mattmoor-sockpuppet:update-deps-knative-eventing-ssb7c-pod-5b5e05

Conversation

@mattmoor-sockpuppet
Copy link
Copy Markdown
Contributor

@mattmoor-sockpuppet mattmoor-sockpuppet commented Jul 9, 2019

Produced via:
dep ensure -update github.com/knative/test-infra knative.dev/pkg
/assign @n3wscott

@mattmoor-sockpuppet
Auto-update dependencies
73bf6d5 
Produced via:
  `dep ensure -update github.com/knative/test-infra knative.dev/pkg`
/assign @n3wscott
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattmoor-sockpuppet
To complete the pull request process, please assign harwayne
You can assign the PR to them by writing /assign @harwayne in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 9, 2019

Hi @mattmoor-sockpuppet. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2019
mattmoor
mattmoor reviewed Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Jul 9, 2019

/retest

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 9, 2019

@mattmoor-sockpuppet: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-integration-tests 73bf6d5 link /test pull-knative-eventing-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Jul 9, 2019

/close
updated via: #1520

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 9, 2019

@n3wscott: Closed this PR.

Details

In response to this:

/close
updated via: #1520

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew pushed a commit to matzew/eventing that referenced this pull request Dec 1, 2021
@openshift-cherrypick-robot @devguyio
Generate slack reporter for 4.9 (knative#1518)
e334dbd 
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

@vaikas vaikas Awaiting requested review from vaikas

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@n3wscott n3wscott

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattmoor-sockpuppet @knative-prow-robot @n3wscott @mattmoor @googlebot