Update pkg, add stats reporter for webhook.#1520
Merged
knative-prow-robot merged 4 commits intoJul 29, 2019
Merged
Conversation
knative-prow-robot
added
size/L
Contributor
Author
|
/retest |
devguyio
approved these changes
Jul 10, 2019
Contributor
devguyio
left a comment
devguyio
left a comment
There was a problem hiding this comment.
lgtm other than trivial negligible comments
|
|
||
| stats, err := webhook.NewStatsReporter() | ||
| if err != nil { | ||
| logger.Fatalw("failed to initialize the stats reporter", zap.Error(err)) |
Contributor
There was a problem hiding this comment.
silly but I think it would be great to capitalize failed
Contributor
Author
There was a problem hiding this comment.
it turns into an error and errors should be lowercase.
|
|
||
| stats, err := webhook.NewStatsReporter() | ||
| if err != nil { | ||
| logger.Fatalw("failed to initialize the stats reporter", zap.Error(err)) |
Contributor
There was a problem hiding this comment.
same about capitalizing failed
knative-prow-robot
added
size/S
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abd4llA, n3wscott, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to knative/pkg#517
Proposed Changes
Release Note