Skip to content

Decision for #1381#1625

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
mikehelmick:issue1381
Aug 7, 2019
Merged

Decision for #1381#1625
knative-prow-robot merged 1 commit into
knative:masterfrom
mikehelmick:issue1381

Conversation

@mikehelmick
Copy link
Copy Markdown
Contributor

Fixes #1381

Proposed Changes

Records user model direction detailed in 1381 as a plan of record for solving the user scenarios detailed in the issue.

Release Note

No release note, since implementation won't land until 0.9.0

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 2, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2019
@mikehelmick
Copy link
Copy Markdown
Contributor Author

/hold

/assign @vaikas-google
/assign @Abd4llA
/assign @rgregg

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2019
@mikehelmick
Copy link
Copy Markdown
Contributor Author

Will hold until all assigned have approved.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 2, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@mikehelmick
Copy link
Copy Markdown
Contributor Author

@Abd4llA @rgregg - ping - would really like to get this submitted before 0.8 cuts.

@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Aug 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Aug 6, 2019

Sorry for delayed response

@mikehelmick
Copy link
Copy Markdown
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@knative-prow-robot knative-prow-robot merged commit aedc143 into knative:master Aug 7, 2019
@mikehelmick mikehelmick deleted the issue1381 branch August 7, 2019 04:02
pierDipi added a commit to pierDipi/eventing that referenced this pull request Mar 14, 2022
See openshift/release#26101

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easier to consume events directly from specific sources

6 participants