Add e2e test for Choice#1642
Merged
Merged
Conversation
knative-prow-robot
added
the
area/test-and-release
Contributor
Author
|
/ok-to-test |
knative-prow-robot
added
size/L
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Harwayne
reviewed
Aug 6, 2019
| } | ||
| } | ||
|
|
||
| // EventFilteringPod creates a Pod that either filter or send the received CloudEvent |
Contributor
There was a problem hiding this comment.
Suggested change
| // EventFilteringPod creates a Pod that either filter or send the received CloudEvent | |
| // EventFilteringPod creates a Pod that either filters or sends the received CloudEvent. |
| } | ||
|
|
||
| func main() { | ||
| // parse the command line flags |
Contributor
There was a problem hiding this comment.
Suggested change
| // parse the command line flags | |
| // Parse the command line flags. |
| expected string | ||
| }{ | ||
| { | ||
| name: "two-cases-pass-first-case-only", |
Contributor
There was a problem hiding this comment.
Why not make these two separate test cases? That way we can remove a for loop below:
table := []struct {
name string
casesConfig caseConfig
expected string
}{
{
name: "don't filter",
casesConfig: caseConfig{
filter: false,
},
},
{
name: "filter",
casesConfig: caseConfig{
filter: true,
},
expected: "choice-filter",
},
}
Contributor
Author
There was a problem hiding this comment.
One choice can have multiple cases. It's a bit confusing because there is only one test (more to come).
pierDipi
pushed a commit
to pierDipi/eventing
that referenced
this pull request
Mar 14, 2022
…ve#1642) * Different cron times for branches * Wrap function invocations in quotes * Add instructions Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Ali Ok <aliok@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1590
Proposed Changes
Not perfect as it misses an assertion about not having a message in the log.