Skip to content

Document steps to create a release#1639

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
grantr:release-process
Aug 5, 2019
Merged

Document steps to create a release#1639
knative-prow-robot merged 3 commits into
knative:masterfrom
grantr:release-process

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented Aug 5, 2019

Fixes #830.

Rendered

As an eventing contributor, I want a concise ordered list of commands to run, but the docs in test-infra don't have those.

These steps were previously documented in #1020 but removed in #1548, replaced with a (less discoverable) comment in hack/release.sh linking to https://github.com/knative/test-infra/tree/master/ci.

/cc @adrcunha

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2019
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@grantr
Copy link
Copy Markdown
Contributor Author

grantr commented Aug 5, 2019

/cc @vaikas-google

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Aug 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@knative-prow-robot knative-prow-robot merged commit 8897763 into knative:master Aug 5, 2019
Comment thread hack/README.md

1. Create a PR for your branch based on the `release-X.Y` branch.

Once the PR is merged, Prow will detect the new commits in the release
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true, as the minor release job only runs once a week. All commits added to the latest release branch will eventually be published together as a new minor release.

@adrcunha
Copy link
Copy Markdown
Contributor

adrcunha commented Aug 7, 2019

These steps were previously documented in #1020 but removed in #1548

My apologies for not noticing you better and correctly documented the automated procedures in 1020. Thanks for the new instructions, they're even better than the previous ones and those in test-infra. I'll shamelessly copy them to test-infra for the other repos. ;)

@grantr grantr deleted the release-process branch August 9, 2019 18:05
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Feb 22, 2022
* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Feb 22, 2022
* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Feb 22, 2022
* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions
pierDipi added a commit to pierDipi/eventing that referenced this pull request Mar 14, 2022
…ve#1640)

* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Ali Ok <aliok@redhat.com>
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Mar 14, 2022
…ve#1642)

* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Ali Ok <aliok@redhat.com>
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Mar 14, 2022
…ve#1643)

* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Ali Ok <aliok@redhat.com>
mgencur referenced this pull request in openshift-knative/eventing Nov 14, 2022
* Different cron times for branches

* Wrap function invocations in quotes

* Add instructions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Ali Ok <aliok@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the release process adequately

5 participants