Skip to content

Point release documentation to knative/test-infra#1548

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
adrcunha:reldoc99
Jul 22, 2019
Merged

Point release documentation to knative/test-infra#1548
knative-prow-robot merged 1 commit into
knative:masterfrom
adrcunha:reldoc99

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Jul 19, 2019

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 19, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jul 19, 2019
@adrcunha
Copy link
Copy Markdown
Contributor Author

adrcunha commented Jul 19, 2019

/retest

daisy-ycguo
daisy-ycguo reviewed Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Harwayne
Harwayne reviewed Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a308bd8 into knative:master Jul 22, 2019
This was referenced Aug 3, 2019
Closed
Merged
matzew added a commit to matzew/eventing that referenced this pull request Dec 10, 2021
@matzew @devguyio
Patch patches to be versioned image strings (knative#1548)
54b04bb 
* Do a sed to use version image string on all patches

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update openshift/release/create-release-branch.sh

Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>

Co-authored-by: Ahmed Abdalla Abdelrehim <aabdelre@redhat.com>
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Sep 22, 2025
@serverless-qe
[main] Update OWNERS file (knative#1548)
1642399 
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dushyanthsc dushyanthsc Awaiting requested review from dushyanthsc

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

2 more reviewers

@Harwayne Harwayne Harwayne left review comments

@daisy-ycguo daisy-ycguo daisy-ycguo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrcunha @knative-prow-robot @Harwayne @daisy-ycguo @googlebot