Performance testing code cleanup#1928
Merged
knative-prow-robot merged 2 commits intoSep 20, 2019
Merged
Conversation
knative-prow-robot
added
the
size/XXL
knative-prow-robot
added
the
area/test-and-release
Contributor
|
/lgtm |
knative-prow-robot
added
the
approved
Contributor
|
@slinkydeveloper looks like you have a merge conflict. |
Renamed test image latencymako to performance Updated README to explain metrics meanings Added baseline configurations Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
cleanup-performance
branch
from
b5a5470 to
ce91323
Compare
Contributor
|
/lgtm |
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
| volumes: | ||
| - name: config-mako | ||
| configMap: | ||
| name: config-mako No newline at end of file |
Contributor
There was a problem hiding this comment.
Add trailing newline:
Suggested change
| name: config-mako | |
| name: config-mako | |
| * Publish latency represents how long the sender took to publish the event to its sink | ||
| * Delivery latency represents how much long the event took to go from the "intent" of publish (before publishing request happens) to the delivery of the event in the receiver | ||
|
|
||
| Throughputs are calculated doing the finite difference of timestamp - count vector. In particular: |
Contributor
There was a problem hiding this comment.
Remove trailing whitespace:
Suggested change
| Throughputs are calculated doing the finite difference of timestamp - count vector. In particular: | |
| Throughputs are calculated doing the finite difference of timestamp - count vector. In particular: |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Nov 16, 2022
* Adding HPA patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding SeccompProfile patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Dec 23, 2022
* Adding HPA patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding SeccompProfile patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> (cherry picked from commit 181f37b)
matzew
added a commit
to creydr/knative-eventing
that referenced
this pull request
Jan 3, 2023
* Adding HPA patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding SeccompProfile patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> (cherry picked from commit 181f37b)
openshift-merge-robot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 9, 2023
* [main] Patches to make OCP 48 -> OCP 4.11 work (knative#1928) * Adding HPA patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding SeccompProfile patch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> (cherry picked from commit 181f37b) * Apply HPA and SeccompProfile patch Signed-off-by: Christoph Stäbler <cstabler@redhat.com> Signed-off-by: Christoph Stäbler <cstabler@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup old latency test/images
Renamed test image latencymako to performance
Updated README to explain metrics meanings
Added baseline configurations
Proposed Changes
/assign grantr
/assign antoineco