Skip to content

[release-v1.8] Apply patches to make OCP 4.8 -> 4.11 work#57

Merged
openshift-merge-robot merged 2 commits into
openshift-knative:release-v1.8from
creydr:apply-patches-to-make-ocp-4.8-to-4.11-work
Jan 9, 2023
Merged

[release-v1.8] Apply patches to make OCP 4.8 -> 4.11 work#57
openshift-merge-robot merged 2 commits into
openshift-knative:release-v1.8from
creydr:apply-patches-to-make-ocp-4.8-to-4.11-work

Conversation

@creydr
Copy link
Copy Markdown
Collaborator

@creydr creydr commented Dec 23, 2022

Currently 48-test-e2e-aws-ocp-48 test is failing, because the eventing-operator does not come up cause of failed to apply non rbac manifest: no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2"

openshift#1928 addressed it and set the apiVersion for HPA to autoscaling/v2beta2. This PR cherry-picks these changes into the 1.8 branch.

@openshift-ci openshift-ci Bot requested review from aliok and lberk December 23, 2022 09:30
@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Dec 23, 2022

/assign @matzew @aliok

@matzew
Copy link
Copy Markdown
Member

matzew commented Dec 23, 2022

Please run make RELEASE=v1.8 generate-release on your PR, @creydr

@creydr creydr force-pushed the apply-patches-to-make-ocp-4.8-to-4.11-work branch from 8214e99 to 0ec8787 Compare December 23, 2022 09:59
@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Dec 23, 2022

Please run make RELEASE=v1.8 generate-release on your PR, @creydr

Done

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Dec 23, 2022

waiting for #61

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Dec 23, 2022

/retest

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Dec 23, 2022

/retest-required

@aliok
Copy link
Copy Markdown
Member

aliok commented Dec 26, 2022

/hold

Waiting until #61 is merged

matzew and others added 2 commits January 3, 2023 10:55
* Adding HPA patch

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding SeccompProfile patch

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
(cherry picked from commit 181f37b)
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@matzew matzew force-pushed the apply-patches-to-make-ocp-4.8-to-4.11-work branch from 0ec8787 to ecee693 Compare January 3, 2023 09:56
@matzew
Copy link
Copy Markdown
Member

matzew commented Jan 3, 2023

rebased and unholding, after 61 got merged (manually)

/unhold

@matzew
Copy link
Copy Markdown
Member

matzew commented Jan 5, 2023

/test 411-test-reconciler-aws-ocp-411

@creydr
Copy link
Copy Markdown
Collaborator Author

creydr commented Jan 9, 2023

@matzew @aliok could you PTAL?
Thanks in advance

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jan 9, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 297d2e4 into openshift-knative:release-v1.8 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants