Skip to content

InMemoryChannel Dispatcher refactor#1933

Merged
knative-prow-robot merged 45 commits into
knative:masterfrom
nachocano:imc-dispatcher
Sep 23, 2019
Merged

InMemoryChannel Dispatcher refactor#1933
knative-prow-robot merged 45 commits into
knative:masterfrom
nachocano:imc-dispatcher

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Fixes #1892
Helps with #1693

Proposed Changes

  • Using cloudEvents SDK instead of "plain" HTTPServer in fanout, multichannelfanout, and swappable.

  • Renaming MessageDispatcher and MessageReceiver to EventDispatcher and EventReceiver

  • Updating UTs.

  • Note that event_dispatcher and event_receiver are renamed files from message_dispatcher and message_receiver. Most of the code is from them. Not sure why github doesn't mark them as renames. Same happened with some UTs

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 19, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2019
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Sep 23, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/retest

Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Please make the TODOs into issues, the cancel the hold.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 23, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
Comment thread pkg/channel/event_dispatcher_test.go
@nachocano
Copy link
Copy Markdown
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

@Harwayne need the magic lgtm again :)

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/channel/event_dispatcher.go Do not exist 82.6%
pkg/channel/event_receiver.go Do not exist 64.2%
pkg/channel/fanout/fanout_handler.go 96.2% 84.6% -11.5
pkg/channel/history.go Do not exist 100.0%
pkg/inmemorychannel/dispatcher.go 18.8% 22.2% 3.5
pkg/utils/context.go Do not exist 0.0%

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@nachocano: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 51ca89b link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@knative-prow-robot knative-prow-robot merged commit cad7a76 into knative:master Sep 23, 2019
mgencur pushed a commit to openshift-knative/eventing that referenced this pull request Nov 18, 2022
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InMemoryChannel Dispatcher Refactor

10 participants