InMemoryChannel Dispatcher refactor#1933
Conversation
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
|
/retest |
Harwayne
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
Please make the TODOs into issues, the cancel the hold.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@Harwayne need the magic lgtm again :) |
|
The following is the coverage report on pkg/.
|
|
@nachocano: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Fixes #1892
Helps with #1693
Proposed Changes
Using cloudEvents SDK instead of "plain" HTTPServer in fanout, multichannelfanout, and swappable.
Renaming MessageDispatcher and MessageReceiver to EventDispatcher and EventReceiver
Updating UTs.
Note that event_dispatcher and event_receiver are renamed files from message_dispatcher and message_receiver. Most of the code is from them. Not sure why github doesn't mark them as renames. Same happened with some UTs
Release Note