Unify sources' labels...#1956
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XS
|
/assign @n3wscott |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| "sources.eventing.knative.dev/cronJobSource": name, | ||
| "eventing.knative.dev/source": controllerAgentName, | ||
| "eventing.knative.dev/source": controllerAgentName, | ||
| "eventing.knative.dev/sourceName": name, |
There was a problem hiding this comment.
this now "matches" what we have on the ApiServersource.
Discussion: sources.eventing.... VS eventing.knative.dev/source ?
There was a problem hiding this comment.
Is there any normative set of labels to be expected by Source CRDs and if not, should such a set be added to the source's spec just under discussion ?
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
@n3wscott or perhaps ? |
|
yo, I refetenced this pr on the spec ticket too
On Wed 25. Sep 2019 at 09:43, Roland Huß ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/reconciler/cronjobsource/resources/labels.go
<#1956 (comment)>:
> @@ -25,7 +25,7 @@ const (
// Labels are the labels attached to all resources based on a CronJobSource.
func Labels(name string) map[string]string {
return map[string]string{
- "sources.eventing.knative.dev/cronJobSource": name,
- "eventing.knative.dev/source": controllerAgentName,
+ "eventing.knative.dev/source": controllerAgentName,
+ "eventing.knative.dev/sourceName": name,
Is there any normative set of labels to be expected by Source CRDs and if
not, should such a set be added to the source's spec just under discussion ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1956?email_source=notifications&email_token=AABGPTT36FIHUBQGPLCBGY3QLMI77A5CNFSM4I2AEDRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF2QUGY#discussion_r327974299>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTU2XWJTXRDZHV5MGU3QLMI77ANCNFSM4I2AEDRA>
.
--
Sent from Gmail Mobile
|
|
/close |
|
@matzew: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Proposed Changes