Skip to content

Unify sources' labels... #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matzew wants to merge 1 commit into from
Closed

Unify sources' labels... #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/reconciler/cronjobsource/resources/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const (
// Labels are the labels attached to all resources based on a CronJobSource.
func Labels(name string) map[string]string {
return map[string]string{
"sources.eventing.knative.dev/cronJobSource": name,
"eventing.knative.dev/source": controllerAgentName,
"eventing.knative.dev/source": controllerAgentName,
"eventing.knative.dev/sourceName": name,
Copy link
Copy Markdown
Member Author

@matzew matzew Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now "matches" what we have on the ApiServersource.

Discussion: sources.eventing.... VS eventing.knative.dev/source ?

Copy link
Copy Markdown
Contributor

@rhuss rhuss Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any normative set of labels to be expected by Source CRDs and if not, should such a set be added to the source's spec just under discussion ?

}
}