Skip to content

wire up controllers / webhooks and add e2e tests#2168

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:flows.controller.wiring
Nov 11, 2019
Merged

wire up controllers / webhooks and add e2e tests#2168
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:flows.controller.wiring

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Nov 11, 2019 •
edited
Loading

Fixes #1913

Proposed Changes

  • Wire up the controllers, webhooks + e2e tests

Release Note

* Introduce parallels.flows.knative.dev and sequences.flows.knative.dev
* Please transition from parallels.messaging.knative.dev to parallels.flows.knative.dev
* Please transition from sequences.messaging.knative.dev to sequences.flows.knative.dev

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 11, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Nov 11, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Nov 11, 2019

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Nov 11, 2019

I'll take a crack at the docs tmw, tracking issue:
knative/docs#1977

@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Nov 11, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2019
@knative-prow-robot knative-prow-robot merged commit fa35b5f into knative:master Nov 11, 2019
@vaikas vaikas deleted the flows.controller.wiring branch November 12, 2019 05:51
@matzew matzew mentioned this pull request Oct 27, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sequence and Parallel in different API group ?

4 participants

@vaikas @knative-prow-robot @lionelvillard @googlebot