Skip to content

Remove forgotten legacy sequence/parallel rule#5850

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
matzew:remove_invalid_messaging_rule_for_sequence_parallel
Oct 27, 2021
Merged

Remove forgotten legacy sequence/parallel rule#5850
knative-prow-robot merged 1 commit into
knative:mainfrom
matzew:remove_invalid_messaging_rule_for_sequence_parallel

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Oct 27, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

…e.dev group 💫

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 27, 2021
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Oct 27, 2021

/assign @lionelvillard

@lionelvillard
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2021

Codecov Report

Merging #5850 (6cab54a) into main (c804fd2) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
- Coverage   82.31%   81.96%   -0.35%     
==========================================
  Files         204      220      +16     
  Lines        6558     7458     +900     
==========================================
+ Hits         5398     6113     +715     
- Misses        794      918     +124     
- Partials      366      427      +61     
Impacted Files Coverage Δ
pkg/scheduler/statefulset/autoscaler.go 78.07% <0.00%> (ø)
.../kafka/nomaxresourcecount/no_max_resource_count.go 82.35% <0.00%> (ø)
pkg/scheduler/statefulset/scheduler.go 78.59% <0.00%> (ø)
...alpriority/remove_with_highest_ordinal_priority.go 66.66% <0.00%> (ø)
...labilitynodepriority/availability_node_priority.go 72.72% <0.00%> (ø)
pkg/scheduler/state/state.go 82.31% <0.00%> (ø)
...lugins/core/podfitsresources/pod_fits_resources.go 100.00% <0.00%> (ø)
pkg/scheduler/placement.go 100.00% <0.00%> (ø)
...priority/remove_with_availability_zone_priority.go 85.71% <0.00%> (ø)
...priority/remove_with_availability_node_priority.go 84.84% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c804fd2...6cab54a. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit ad74b38 into knative:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants