Skip to content

Add chizhg to eventing productivity approvers#2326

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
chizhg:AddAsTestApprover
Dec 17, 2019
Merged

Add chizhg to eventing productivity approvers#2326
knative-prow-robot merged 1 commit into
knative:masterfrom
chizhg:AddAsTestApprover

Conversation

@chizhg
Copy link
Copy Markdown
Contributor

@chizhg chizhg commented Dec 17, 2019

From ROLES.md

Reviewer of the codebase for at least 3 months.

First review: April 2019

Primary reviewer for at least 10 substantial PRs to the codebase.

28 PRs:
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Alionelvillard+commenter%3Alionelvillard+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+

Merged at least 30 PRs to the codebase.

62 PRs:
https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Achizhg+is%3Amerged

Nominated by an area lead with no objections from other leads

/cc @adrcunha
/cc @grantr
/cc @nachocano

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2019
@adrcunha
Copy link
Copy Markdown
Contributor

Thanks for the justification, Chi. However, I think that you being added as an approver of test-infra (knative/test-infra#1590) is already enough.

/retest
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@lionelvillard
Copy link
Copy Markdown
Contributor

The link filtering PRs is wrong (bad copy and paste). The correct one is:

https://github.com/knative/eventing/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+-author%3Achizhg+commenter%3Achizhg+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+

The number of PRs is the same though :-)

@n3wscott
Copy link
Copy Markdown
Contributor

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, chizhg, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@knative-prow-robot knative-prow-robot merged commit 32aa0d4 into knative:master Dec 17, 2019
@chizhg chizhg deleted the AddAsTestApprover branch December 17, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants