Add e2e test cases for Channel-Subscription model by chizhg · Pull Request #976 · knative/eventing

chizhg · 2019-03-26T17:45:33Z

Added e2e test cases for the following two scenarios:

Event delivery through channel chain
Event transformation

More information can be found in the test case comment.

PS. currently there's some duplicate code in the test cases, we can probably refactor them into common functions in the future.

chizhg · 2019-03-26T18:29:38Z

/retest

chizhg · 2019-03-26T23:00:53Z

/retest

vaikas · 2019-03-27T18:24:30Z

Thanks for adding tests!!! 💯

syedriko · 2019-03-27T18:36:18Z

This is a generic test, it doesn't depend on a particular CCP. Will it run against the various channels/channel providers? Through what mechanism?

…ventToChannel

chizhg · 2019-03-29T21:46:48Z

This is a generic test, it doesn't depend on a particular CCP. Will it run against the various channels/channel providers? Through what mechanism?

Currently it's only running against the default in-memory channel. When we have support for setting up other CCPs like Kafka, we can reuse the same test cases to test them by simply changing the Provisioner flag.

chizhg · 2019-04-02T22:35:36Z

/retest

Harwayne

/approve
/lgtm

knative-prow-robot · 2019-04-04T18:05:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fredy-Z, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [Harwayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chizhg · 2019-04-05T19:16:28Z

/retest

chizhg · 2019-04-05T19:45:13Z

/retest

chizhg · 2019-04-05T20:28:59Z

/retest

chizhg · 2019-04-05T20:57:55Z

/retest

Harwayne

/lgtm

chizhg · 2019-04-05T22:14:28Z

/retest

chizhg · 2019-04-05T22:58:11Z

/retest
The E2E tests are taking a longer time and cannot finish with 10 minutes, which is the default timeout for go test. So I'll have to change it to a larger value for now.
In the next PR, I'll change the test case to run parallel and hopefully we can make the running time shorter.

BTW, the current timeout for Serving e2e/conformance tests is 30 minutes.

Harwayne

/lgtm

…kerfiler-v1.15 [release-v1.15] Make adapter independent from brokerfilter package

chizhg added 6 commits March 25, 2019 21:06

add two e2e test case for Channel and Subscription in Eventing

0408940

Merge branch 'master' into AddE2ETestCases

239d792

change comment

4546739

add default encoding and some comments

13475d2

fix comment error

3542880

rename the test case

ad91d20

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2019

knative-prow-robot requested review from Harwayne and grantr March 26, 2019 17:45

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2019

chizhg added 4 commits March 26, 2019 13:25

set up in the first fine

53283c7

try to find presubmit tests fail reason

15ee257

add back the e2e test cases

3b1acb2

add +build e2e for the test cases

94ff59c

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2019

change timeout to 2mins

dc3aaef

adrcunha reviewed Mar 27, 2019

View reviewed changes

Comment thread test/e2e/event_transformation_test.go Outdated

Comment thread test/test_images/logevents/main.go Outdated

Comment thread test/test_images/transformevents/main.go

syedriko reviewed Mar 27, 2019

View reviewed changes

Comment thread test/e2e/e2e.go

Comment thread test/e2e/e2e.go Outdated

Comment thread test/e2e/event_transformation_test.go Outdated

Comment thread test/e2e/channel_chain_test.go Outdated

vaikas reviewed Mar 27, 2019

View reviewed changes

Comment thread test/test_images/logevents/main.go Outdated

Comment thread test/e2e/e2e.go Outdated

Comment thread test/e2e/e2e.go Outdated

Comment thread test/e2e/e2e.go Outdated

Comment thread test/e2e/channel_chain_test.go Outdated

syedriko mentioned this pull request Mar 28, 2019

e2e test for Apache Kafka CCP #901

Closed

chizhg added 2 commits March 29, 2019 12:28

fix code review problems

5c5475d

refactor common functions like CreatePodAndServiceReady and SendFakeE…

7d059a0

…ventToChannel

chizhg changed the title ~~Add e2e test cases~~ Add e2e test cases for Channel-Subscription model Mar 29, 2019

modify the initialization sequence a little bit

7a7ad80

chizhg added 3 commits April 1, 2019 21:26

move provisioner check ahead

24a4146

remove duplicate import

bef2c43

minor comment change

deb6b65

Harwayne reviewed Apr 2, 2019

View reviewed changes

fix the code review issues

52db472

matzew mentioned this pull request Apr 4, 2019

e2e test for kafka source knative/eventing-contrib#272

Closed

Harwayne reviewed Apr 4, 2019

View reviewed changes

knative-prow-robot assigned Harwayne Apr 4, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019

Merge branch 'master' into AddE2ETestCases

4f2e04f

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019

Harwayne reviewed Apr 5, 2019

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019

change the timeout to 20 mins, by default it is 10 mins

36264fc

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019

Harwayne reviewed Apr 5, 2019

View reviewed changes

knative-prow-robot merged commit 339f227 into knative:master Apr 5, 2019

chizhg deleted the AddE2ETestCases branch September 2, 2019 04:22

chizhg mentioned this pull request Dec 17, 2019

Add chizhg to eventing productivity approvers #2326

Merged

creydr added a commit to creydr/knative-eventing that referenced this pull request Dec 11, 2024

Merge pull request knative#976 from creydr/cp-adapter-independent-bro…

9977db0

…kerfiler-v1.15 [release-v1.15] Make adapter independent from brokerfilter package

Conversation

chizhg commented Mar 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chizhg commented Mar 26, 2019

Uh oh!

chizhg commented Mar 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vaikas commented Mar 27, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

syedriko commented Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chizhg commented Mar 29, 2019

Uh oh!

chizhg commented Apr 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Apr 4, 2019

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

chizhg commented Apr 5, 2019

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chizhg commented Mar 26, 2019 •

edited

Loading

syedriko commented Mar 27, 2019 •

edited

Loading