Make broker filter/ingress default PrometheusPort to 9092 (as long as different than 9090)

[yolocs]

Fixes one problem pointed out in #2405

Proposed Changes

• Defaulting the PrometheusPort to 9092 to avoid conflict with serving queue-proxy metrics port.

Release Note

Make broker filter/ingress default PrometheusPort to 9092

[chizhg]

/retest

[yolocs]

Also @nachocano

[grantr]

Do we also need to change a configuration elsewhere to tell it about this new port?

[yolocs]

Do we also need to change a configuration elsewhere to tell it about this new port?

My understanding is that this port is not actively used. Users can set up port forwarding to this port to check out metrics. @yanweiguo for confirmation.

[vaikas]

Just curious if we should upstream this change rather than have our own copy here?

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yanweiguo]

Do we also need to change a configuration elsewhere to tell it about this new port?

My understanding is that this port is not actively used. Users can set up port forwarding to this port to check out metrics. @yanweiguo for confirmation.

This port is where the metrics are exposed in Prometheus format. If you're reading this port from somewhere, you need to change to this new port.