Skip to content

Switch the metrics port of the Channel Based Broker components to 9092#3162

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
Harwayne:broker-metrics-port-9092
May 26, 2020
Merged

Switch the metrics port of the Channel Based Broker components to 9092#3162
knative-prow-robot merged 2 commits into
knative:masterfrom
Harwayne:broker-metrics-port-9092

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

Proposed Changes

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@Harwayne
Copy link
Copy Markdown
Contributor Author

/assign @yolocs

@Harwayne
Copy link
Copy Markdown
Contributor Author

/retest

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/broker/broker.go 81.2% 82.4% 1.3

@yolocs
Copy link
Copy Markdown
Contributor

yolocs commented May 26, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@knative-prow-robot knative-prow-robot merged commit 413f31e into knative:master May 26, 2020
@Harwayne Harwayne deleted the broker-metrics-port-9092 branch May 26, 2020 20:13
@Harwayne Harwayne mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants